Re: [PATCH] fanotify: Fix sys_fanotify_mark() on native x86-32

From: Borislav Petkov
Date: Tue Dec 01 2020 - 10:52:54 EST


On Tue, Dec 01, 2020 at 10:48:10AM +0100, Jan Kara wrote:
> On Mon 30-11-20 17:30:59, Brian Gerst wrote:
> > Commit 121b32a58a3a converted native x86-32 which take 64-bit arguments to
> > use the compat handlers to allow conversion to passing args via pt_regs.
> > sys_fanotify_mark() was however missed, as it has a general compat handler.
> > Add a config option that will use the syscall wrapper that takes the split
> > args for native 32-bit.
> >
> > Reported-by: Paweł Jasiak <pawel@xxxxxxxxxx>
> > Fixes: 121b32a58a3a ("x86/entry/32: Use IA32-specific wrappers for syscalls taking 64-bit arguments")
> > Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>
>
> Thanks for the patch! It looks good to me. Feel free to add:
>
> Acked-by: Jan Kara <jack@xxxxxxx>
>
> I assume you plan to push this via x86 tree given the changes are mostly
> there, don't you?

Looks sane to me too, I guess I can send it to Linus even now so that it
lands in 5.10. Is that what you'd prefer Jan?

Also, Paweł, can you give that one a try to see if it fixes your case?
It should...

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette