Re: [PATCH net-next v1 0/3] vsock: Add flag field in the vsock address

[Paraschiv, Andra-Irina]

On 01/12/2020 18:27, Stefano Garzarella wrote:
> Hi Andra,
>
> On Tue, Dec 01, 2020 at 05:25:02PM +0200, Andra Paraschiv wrote:
> > vsock enables communication between virtual machines and the host 
> > they are
> > running on. Nested VMs can be setup to use vsock channels, as the multi
> > transport support has been available in the mainline since the v5.5 
> > Linux kernel
> > has been released.
> >
> > Implicitly, if no host->guest vsock transport is loaded, all the 
> > vsock packets
> > are forwarded to the host. This behavior can be used to setup 
> > communication
> > channels between sibling VMs that are running on the same host. One 
> > example can
> > be the vsock channels that can be established within AWS Nitro Enclaves
> > (see Documentation/virt/ne_overview.rst).
> >
> > To be able to explicitly mark a connection as being used for a 
> > certain use case,
> > add a flag field in the vsock address data structure. The 
> > "svm_reserved1" field
> > has been repurposed to be the flag field. The value of the flag will 
> > then be
> > taken into consideration when the vsock transport is assigned.
> >
> > This way can distinguish between nested VMs / local communication and 
> > sibling
> > VMs use cases. And can also setup one or more types of communication 
> > at the same
> > time.
>
> Thanks to work on this, I've left you a few comments, but I think this
> is the right way to support nested and sibling communication together.

Hi Stefano,

Thanks also for taking time to review and both you and Stefan for 
sharing an overview of this proposed option.

I'm going through the comments and will send out the v2 of the patch 
series as I have the changes done and validated.

Thanks,
Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.