Re: [PATCH v1 1/4] usb: typec: tcpm: Pass down negotiated rev to update retry count

[Badhri Jagan Sridharan]

Sure. Done ! Just sent out v2 version of the patch.

Thanks,
Badhri.


On Tue, Dec 1, 2020 at 2:32 AM Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 30, 2020 at 08:22:34PM -0800, Badhri Jagan Sridharan wrote:
> > nRetryCount was updated from 3 to 2 between PD2.0 and PD3.0 spec.
> > nRetryCount in "Table 6-34 Counter parameters" of the PD 2.0
> > spec is set to 3, whereas, nRetryCount in "Table 6-59 Counter
> > parameters" is set to 2.
> >
> > Pass down negotiated rev in pd_transmit so that low level chip
> > drivers can update the retry count accordingly before attempting
> > packet transmission.
> >
> > This helps in passing "TEST.PD.PORT.ALL.02" of the
> > "Power Delivery Merged" test suite which was initially failing
> > with "The UUT did not retransmit the message nReryCount times"
> >
> > Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx>
> > ---
> >  drivers/usb/typec/tcpm/tcpm.c | 2 +-
> >  include/linux/usb/tcpm.h      | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> > index 3bbc1f10af49..c73bc3a8356a 100644
> > --- a/drivers/usb/typec/tcpm/tcpm.c
> > +++ b/drivers/usb/typec/tcpm/tcpm.c
> > @@ -667,7 +667,7 @@ static int tcpm_pd_transmit(struct tcpm_port *port,
> >               tcpm_log(port, "PD TX, type: %#x", type);
> >
> >       reinit_completion(&port->tx_complete);
> > -     ret = port->tcpc->pd_transmit(port->tcpc, type, msg);
> > +     ret = port->tcpc->pd_transmit(port->tcpc, type, msg, port->negotiated_rev);
> >       if (ret < 0)
> >               return ret;
> >
> > diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h
> > index e68aaa12886f..efaedd7e8a18 100644
> > --- a/include/linux/usb/tcpm.h
> > +++ b/include/linux/usb/tcpm.h
> > @@ -121,7 +121,7 @@ struct tcpc_dev {
> >                             enum typec_cc_status cc);
> >       int (*try_role)(struct tcpc_dev *dev, int role);
> >       int (*pd_transmit)(struct tcpc_dev *dev, enum tcpm_transmit_type type,
> > -                        const struct pd_message *msg);
> > +                        const struct pd_message *msg, unsigned int negotiated_rev);
> >       int (*set_bist_data)(struct tcpc_dev *dev, bool on);
> >       int (*enable_frs)(struct tcpc_dev *dev, bool enable);
> >       void (*frs_sourcing_vbus)(struct tcpc_dev *dev);
>
> I think this will break bisectability. You need to change the users of
> that at in the same commit.
>
> thanks,
>
> --
> heikki