Re: [PATCH 1/6] arm64: dts: qcom: sm8250: add apr and its services

[Srinivas Kandagatla]

Many thanks Bjorn for review,

On 01/12/2020 19:25, Bjorn Andersson wrote:
> On Tue 01 Dec 09:37 CST 2020, Srinivas Kandagatla wrote:
>
> > Add apr node and its associated services required for audio on RB5.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sm8250.dtsi | 56 ++++++++++++++++++++++++++++
> >   1 file changed, 56 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > index 65acd1f381eb..3b4e98b13d36 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> > @@ -11,6 +11,8 @@
> >   #include <dt-bindings/mailbox/qcom-ipcc.h>
> >   #include <dt-bindings/power/qcom-aoss-qmp.h>
> >   #include <dt-bindings/power/qcom-rpmpd.h>
> > +#include <dt-bindings/soc/qcom,apr.h>
> > +#include <dt-bindings/sound/qcom,q6afe.h>
>
> Please move this line one step down to maintain the alphabetical sort
> order.

I agree with all the comments on this patch as well as other patches, 
will send v2 with those fixed!

Thanks,
srini
> Thanks,
> Bjorn
>
> >   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> >   #include <dt-bindings/thermal/thermal.h>
> >   
> > @@ -2620,6 +2622,60 @@
> >   				label = "lpass";
> >   				qcom,remote-pid = <2>;
> >   
> > +				apr {
> > +					compatible = "qcom,apr-v2";
> > +					qcom,glink-channels = "apr_audio_svc";
> > +					qcom,apr-domain = <APR_DOMAIN_ADSP>;
> > +					#address-cells = <1>;
> > +					#size-cells = <0>;
> > +
> > +					apr-service@3 {
> > +						reg = <APR_SVC_ADSP_CORE>;
> > +						compatible = "qcom,q6core";
> > +						qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> > +					};
> > +
> > +					q6afe: apr-service@4 {
> > +						compatible = "qcom,q6afe";
> > +						reg = <APR_SVC_AFE>;
> > +						qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> > +						q6afedai: dais {
> > +							compatible = "qcom,q6afe-dais";
> > +							#address-cells = <1>;
> > +							#size-cells = <0>;
> > +							#sound-dai-cells = <1>;
> > +						};
> > +
> > +						q6afecc: cc {
> > +							compatible = "qcom,q6afe-clocks";
> > +							#clock-cells = <2>;
> > +						};
> > +					};
> > +
> > +					q6asm: apr-service@7 {
> > +						compatible = "qcom,q6asm";
> > +						reg = <APR_SVC_ASM>;
> > +						qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> > +						q6asmdai: dais {
> > +							compatible = "qcom,q6asm-dais";
> > +							#address-cells = <1>;
> > +							#size-cells = <0>;
> > +							#sound-dai-cells = <1>;
> > +							iommus = <&apps_smmu 0x1801 0x0>;
> > +						};
> > +					};
> > +
> > +					q6adm: apr-service@8 {
> > +						compatible = "qcom,q6adm";
> > +						reg = <APR_SVC_ADM>;
> > +						qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> > +						q6routing: routing {
> > +							compatible = "qcom,q6adm-routing";
> > +							#sound-dai-cells = <0>;
> > +						};
> > +					};
> > +				};
> > +
> >   				fastrpc {
> >   					compatible = "qcom,fastrpc";
> >   					qcom,glink-channels = "fastrpcglink-apps-dsp";
> > --
> > 2.21.0