RE: [PATCH 07/22] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host

[Thokala, Srikanth]

Hi Greg,

> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, December 1, 2020 3:48 PM
> To: mgross@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; markgross@xxxxxxxxxx; Gretzinger, Adam R
> <adam.r.gretzinger@xxxxxxxxx>; Thokala, Srikanth
> <srikanth.thokala@xxxxxxxxx>; Derek Kiernan <derek.kiernan@xxxxxxxxxx>;
> Dragan Cvetic <dragan.cvetic@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>
> Subject: Re: [PATCH 07/22] misc: xlink-pcie: lh: Add PCIe EPF driver for
> Local Host
> 
> On Mon, Nov 30, 2020 at 03:06:52PM -0800, mgross@xxxxxxxxxxxxxxx wrote:
> > +#define XPCIE_VERSION_MAJOR 0
> > +#define XPCIE_VERSION_MINOR 5
> > +#define XPCIE_VERSION_BUILD 0
> > +#define _TOSTR(X) #X
> > +#define _VERSION(A, B, C) _TOSTR(A) "." _TOSTR(B) "." _TOSTR(C)
> > +#define XPCIE_DRIVER_VERSION \
> > +	_VERSION(XPCIE_VERSION_MAJOR, XPCIE_VERSION_MINOR,
> XPCIE_VERSION_BUILD)
> > +
> > +struct xpcie_version {
> > +	u8 major;
> > +	u8 minor;
> > +	u16 build;
> > +} __packed;
> 
> Now that the driver will be in the tree, there is no need for this
> structure or these fields, right?  It will just be the version of the
> kernel.  Otherwise something like this will never be correct, given
> stable kernel releases and enterprise kernel releases, and loads of
> other messy backported trees.  Just stick to the kernel release number
> please, that's the only sane thing.
> 

Sure, I agree. I will fix it in my v2.

thanks!
Srikanth

> thanks,
> 
> greg k-h