Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

[Lukasz Stelmach]

It was <2020-12-02 śro 09:18>, when Jakub Kicinski wrote:
> On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote:
>> >> +	status = netif_rx(skb);  
>> >
>> > If I'm reading things right this is in process context, so netif_rx_ni()
>> >  
>> 
>> Is it? The stack looks as follows
>> 
>>     ax88796c_skb_return()
>>     ax88796c_rx_fixup()
>>     ax88796c_receive()
>>     ax88796c_process_isr()
>>     ax88796c_work()
>> 
>> and ax88796c_work() is a scheduled in the system_wq.
>
> Are you asking if work queue gets run in process context? It does.
>

Thanks. Changed.

>> >> +	if (status != NET_RX_SUCCESS)
>> >> +		netif_info(ax_local, rx_err, ndev,
>> >> +			   "netif_rx status %d\n", status);  
>> >
>> > Again, it's inadvisable to put per packet prints without any rate
>> > limiting in the data path.  
>> 
>> Even if limmited by the msglvl flag, which is off by default?
>
> I'd err on the side of caution, but up to you.
>

It isn't very common, but a few drivers do this.

Thank you.
-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Attachment: signature.asc
Description: PGP signature