Re: [PATCH 2/2] pinctrl: qcom: Add SM8350 pinctrl driver

From: Linus Walleij
Date: Fri Dec 04 2020 - 04:25:35 EST


On Thu, Dec 3, 2020 at 8:09 AM Vinod Koul <vkoul@xxxxxxxxxx> wrote:

> From: Raghavendra Rao Ananta <rananta@xxxxxxxxxxxxxx>
>
> This adds pincontrol driver for tlmm block found in SM8350 SoC
>
> Signed-off-by: Raghavendra Rao Ananta <rananta@xxxxxxxxxxxxxx>
> Signed-off-by: Jeevan Shriram <jshriram@xxxxxxxxxxxxxx>
> [vkoul: rebase and tidy up for upstream]
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
(...)

> +config PINCTRL_SM8350
> + tristate "Qualcomm Technologies Inc SM8350 pin controller driver"
> + depends on GPIOLIB && OF
> + select PINCTRL_MSM

This needs to be
depends on PINCTRL_MSM
due to the recent changes to allow modularization.

Yours,
Linus Walleij