Re: [PATCH] firmware: tegra: bpmp: fix T234 build failure

[Thierry Reding]

On Fri, Dec 04, 2020 at 12:06:20AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> When only Tegra 234 is enabled, the bpmp driver fails
> to build:
> 
> drivers/firmware/tegra/bpmp.c:861:51: error: 'tegra186_soc' undeclared here (not in a function)
>   861 |  { .compatible = "nvidia,tegra186-bpmp", .data = &tegra186_soc },
>       |                                                   ^~~~~~~~~~~~
> 
> Fix the #ifdef statement to match the location in which this
> symbol is used.
> 
> Fixes: 0ebdf11699d0 ("firmware: tegra: Enable BPMP support on Tegra234")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/firmware/tegra/Makefile       | 1 +
>  drivers/firmware/tegra/bpmp-private.h | 3 ++-
>  drivers/firmware/tegra/bpmp.c         | 3 ++-
>  3 files changed, 5 insertions(+), 2 deletions(-)

Sigh... I wonder if I should just give up and eliminate all
ARCH_TEGRA_XYZ_SOC options. There's not a lot that we gain by keeping
them around and most people will be building multi-platform
configurations anyway, so there's very little point to it.

Anyway, this looks good, so:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Let me know if you'd prefer me to pick this up and send as a follow-up
pull request for Tegra.

Thierry

Attachment: signature.asc
Description: PGP signature