Re: [PATCH 17/22] xlink-core: Add xlink core device tree bindings

From: Rob Herring
Date: Mon Dec 07 2020 - 11:03:36 EST


On Tue, 01 Dec 2020 14:35:06 -0800, mgross@xxxxxxxxxxxxxxx wrote:
> From: Seamus Kelly <seamus.kelly@xxxxxxxxx>
>
> Add device tree bindings for keembay-xlink.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Reviewed-by: Mark Gross <mgross@xxxxxxxxxxxxxxx>
> Signed-off-by: Seamus Kelly <seamus.kelly@xxxxxxxxx>
> Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@xxxxxxxxx>
> ---
> .../bindings/misc/intel,keembay-xlink.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
>


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml:21:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml: 'additionalProperties' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml


See https://patchwork.ozlabs.org/patch/1409184

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.