Re: [PATCH v14 09/10] arch, mm: wire up memfd_secret system call were relevant

From: Andrew Morton
Date: Mon Dec 07 2020 - 20:36:00 EST


On Mon, 7 Dec 2020 18:00:06 +0200 Mike Rapoport <rppt@xxxxxxxxxxxxx> wrote:

> >
> > I can't see where was it defined for arm64 after it looks like Andrew has
> > deleted the above chunk. Thus, we have a warning using this .config:
> >
> > https://cailca.coding.net/public/linux/mm/git/files/master/arm64.config
> >
> > <stdin>:1539:2: warning: #warning syscall memfd_secret not implemented [-Wcpp]
>
> I was under the impression that Andrew only removed the #ifdef...
>
> Andrew, can you please restore syscall definition for memfd_secret() in
> include/uapi/asm-generic/unistd.h?
>

urgh, OK, that seems to have got lost in the (moderate amount of)
conflict resolution).

--- a/include/uapi/asm-generic/unistd.h~arch-mm-wire-up-memfd_secret-system-call-were-relevant-fix
+++ a/include/uapi/asm-generic/unistd.h
@@ -863,9 +863,13 @@ __SYSCALL(__NR_process_madvise, sys_proc
__SYSCALL(__NR_watch_mount, sys_watch_mount)
#define __NR_epoll_pwait2 442
__SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
+#ifdef __ARCH_WANT_MEMFD_SECRET
+#define __NR_memfd_secret 443
+__SYSCALL(__NR_memfd_secret, sys_memfd_secret)
+#endif

#undef __NR_syscalls
-#define __NR_syscalls 443
+#define __NR_syscalls 444

/*
* 32 bit systems traditionally used different
_