RE: [PATCH v3] ath10k: add option for chip-id based BDF selection

[Rakesh Pillai]

Hi,


> -----Original Message-----
> From: Abhishek Kumar <kuabhs@xxxxxxxxxxxx>
> Sent: Tuesday, December 8, 2020 4:50 AM
> To: kvalo@xxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; kuabhs@xxxxxxxxxxxx; linux-
> wireless@xxxxxxxxxxxxxxx; ath10k@xxxxxxxxxxxxxxxxxxx;
> pillair@xxxxxxxxxxxxxx; briannorris@xxxxxxxxxxxx;
> dianders@xxxxxxxxxxxx; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Subject: [PATCH v3] ath10k: add option for chip-id based BDF selection
> 
> In some devices difference in chip-id should be enough to pick
> the right BDF. Add another support for chip-id based BDF selection.
> With this new option, ath10k supports 2 fallback options.
> 
> The board name with chip-id as option looks as follows
> board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'
> 
> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1
> Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1
> Signed-off-by: Abhishek Kumar <kuabhs@xxxxxxxxxxxx>
> ---
> 
> Changes in v3:
> - Resurreted Patch V1 because as per discussion we do need two
> fallback board names and refactored ath10k_core_create_board_name.
> 
>  drivers/net/wireless/ath/ath10k/core.c | 41 +++++++++++++++++++-------
>  1 file changed, 30 insertions(+), 11 deletions(-)

Reviewed-by: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>

Thanks,
Rakesh Pillai.