[PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

From: Xiaohui Zhang
Date: Tue Dec 08 2020 - 08:03:36 EST


From: Zhang Xiaohui <ruc_zhangxiaohui@xxxxxxx>

mwifiex_config_scan() calls memcpy() without checking
the destination size may trigger a buffer overflower,
which a local user could use to cause denial of service
or the execution of arbitrary code.
Fix it by putting the length check before calling memcpy().

Signed-off-by: Zhang Xiaohui <ruc_zhangxiaohui@xxxxxxx>
---
drivers/net/wireless/marvell/mwifiex/scan.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c b/drivers/net/wireless/marvell/mwifiex/scan.c
index c2a685f63..b1d90678f 100644
--- a/drivers/net/wireless/marvell/mwifiex/scan.c
+++ b/drivers/net/wireless/marvell/mwifiex/scan.c
@@ -930,6 +930,8 @@ mwifiex_config_scan(struct mwifiex_private *priv,
"DIRECT-", 7))
wildcard_ssid_tlv->max_ssid_length = 0xfe;

+ if (ssid_len > 1)
+ ssid_len = 1;
memcpy(wildcard_ssid_tlv->ssid,
user_scan_in->ssid_list[i].ssid, ssid_len);

--
2.17.1