Re: [PATCH] mm/filemap: add static for function __add_to_page_cache_locked

From: Tony Luck
Date: Wed Dec 09 2020 - 16:00:39 EST


On Mon, Dec 7, 2020 at 4:36 PM Michal Kubecek <mkubecek@xxxxxxx> wrote:
> Not removal, commit 3351b16af494 ("mm/filemap: add static for function
> __add_to_page_cache_locked") made the function static which breaks the
> build in btfids phase - but it seems to happen only on some
> architectures. In our case, ppc64, ppc64le and riscv64 are broken,
> x86_64, i586 and s390x succeed. (I made a mistake above, aarch64 did not
> fail - but only because it was not built at all.)

x86_64 fails for me:

LD vmlinux
BTFIDS vmlinux
FAILED unresolved symbol __add_to_page_cache_locked
make: *** [Makefile:1170: vmlinux] Error 255