Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

[Zheng Zengkai]

Hi Anton and Andrew,

> Hi Andrew,
>
> Ah, oops!  Thank you and apologies.  Quite right the alternative patch was even better.  No need to apply this patch after all...
>
> Zheng, the log_page_mask variable was removed altogether so your patch no longer makes sense.
>
> Best regards,
>
> 	Anton
>
> > On 10 Dec 2020, at 02:36, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov <anton@xxxxxxxxxx> wrote:
> >
> > > Can you please apply this?
> > >
> > > ...
> > >
> > > > --- a/fs/ntfs/logfile.c
> > > > +++ b/fs/ntfs/logfile.c
> > > > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp)
> > > > 	 * optimize log_page_size and log_page_bits into constants.
> > > > 	 */
> > > > 	log_page_bits = ntfs_ffs(log_page_size) - 1;
> > > > -	size &= ~(s64)(log_page_size - 1);
> > > > +	size &= ~(s64)(log_page_mask);
> > > > 	/*
> > > > 	 * Ensure the log file is big enough to store at least the two restart
> > > > 	 * pages and the minimum number of log record pages.
> > https://lore.kernel.org/lkml/1604821092-54631-1-git-send-email-alex.shi@xxxxxxxxxxxxxxxxx/
> > addressed this?
It's ok, thank you all the same!