Re: [PATCH v16 4/4] bus: mhi: Add userspace client interface driver

From: Jeffrey Hugo
Date: Thu Dec 10 2020 - 10:04:32 EST


On 12/10/2020 1:55 AM, Greg KH wrote:
On Wed, Dec 09, 2020 at 11:21:25PM -0800, Hemant Kumar wrote:
This MHI client driver allows userspace clients to transfer
raw data between MHI device and host using standard file operations.
Driver instantiates UCI device object which is associated to device
file node. UCI device object instantiates UCI channel object when device
file node is opened. UCI channel object is used to manage MHI channels
by calling MHI core APIs for read and write operations. MHI channels
are started as part of device open(). MHI channels remain in start
state until last release() is called on UCI device file node. Device
file node is created with format

/dev/<mhi_device_name>

Currently it supports QMI channel.

Signed-off-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Reviewed-by: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>
Tested-by: Loic Poulain <loic.poulain@xxxxxxxxxx>
---

Can you provide a pointer to the open-source userspace program that will
be talking to this new kernel driver please? That should be part of the
changelog here.

Its listed in the documentation file (patch 3 in the series). I'm guessing you still want it in the change log though, so Hemant should probably take care of that.

--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.