Re: [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

From: Borislav Petkov
Date: Thu Dec 10 2020 - 13:50:53 EST


On Thu, Dec 10, 2020 at 12:19:46PM +0800, Chris Chiu wrote:
> From: Dan Nicholson <nicholson@xxxxxxxxxxxxx>
>
> The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi
> reboot.

Is that what the "hard disk crash" in the comment below, refers to?

> It works without problem after adding the parameter
> reboot=bios.
>
> Signed-off-by: Dan Nicholson <nicholson@xxxxxxxxxxxxx>
> Signed-off-by: Chris Chiu <chiu@xxxxxxxxxxxxx>
> Signed-off-by: Jian-Hong Pan <jhp@xxxxxxxxxxxxx>

What's Jian's S-o-b tag supposed to mean?

> ---
>
> v2:
> - fix typo in the commit message.
>
> arch/x86/kernel/reboot.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index db115943e8bd..a03344616cd9 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -467,6 +467,16 @@ static const struct dmi_system_id reboot_dmi_table[] __initconst = {
> },
> },
>
> + /* GIGABYTE */
> + { /* Workaround hard disk crash on ACPI reboot */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette