Re: [PATCH] x86/sgx: Synchronize encl->srcu in sgx_encl_release().

From: Jarkko Sakkinen
Date: Wed Dec 16 2020 - 07:26:57 EST


On Tue, Dec 15, 2020 at 02:04:10PM -0800, Sean Christopherson wrote:
> On Tue, Dec 15, 2020, Jarkko Sakkinen wrote:
> > On Mon, Dec 14, 2020 at 11:01:32AM -0800, Sean Christopherson wrote:
> > > Haitao reported the bug, and for all intents and purposes provided the fix. I
> > > just did the analysis to verify that there was a legitimate bug and that the
> > > synchronization in sgx_encl_release() was indeed necessary.
> >
> > Good and valid point. The way I see it, the tags should be:
> >
> > Reported-by: Haitao Huang <haitao.huang@xxxxxxxxxxxxxxx>
> > Suggested-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> >
> > Haitao pointed out the bug but from your analysis I could resolve that
> > this is the fix to implement, and was able to write the long
> > description for the commit.
> >
> > Does this make sense to you?
>
> Yep, works for me.

I'll just add two suggested-by's. Process guide does not forbid that
and it best describes matters.

/Jarkko