RE: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support

[Ardelean, Alexandru]

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Monday, December 21, 2020 4:37 PM
> To: Ardelean, Alexandru <alexandru.Ardelean@xxxxxxxxxx>
> Cc: linux-spi <linux-spi@xxxxxxxxxxxxxxx>; devicetree
> <devicetree@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; Bogdan, Dragos <Dragos.Bogdan@xxxxxxxxxx>;
> Mark Brown <broonie@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>
> Subject: Re: [PATCH v5 2/3] spi: Add SPI_NO_TX/RX support
> 
> On Mon, Dec 21, 2020 at 4:34 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Mon, Dec 21, 2020 at 4:15 PM Alexandru Ardelean
> > <alexandru.ardelean@xxxxxxxxxx> wrote:
> > >
> > > From: Dragos Bogdan <dragos.bogdan@xxxxxxxxxx>
> > >
> > > Transmit/receive only is a valid SPI mode. For example, the MOSI/TX
> > > line might be missing from an ADC while for a DAC the MISO/RX line
> > > may be optional. This patch adds these two new modes: SPI_NO_TX and
> > > SPI_NO_RX. This way, the drivers will be able to identify if any of
> > > these two lines is missing and to adjust the transfers accordingly.
> > >
> > > Signed-off-by: Dragos Bogdan <dragos.bogdan@xxxxxxxxxx>
> >
> > Missed Co-developed-by: Alexandru ... ?

Nah, that's fine from my side without that tag.

> >
> > Anyway, looks good to me,
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> 
> One nit, though...
> 
> > > -               "setup: can not select dual and quad at the same time\n");
> > > +               "setup: can not select any two of dual, quad and no-rx/tx "
> > > +               "at the same time\n");
> 
> Can we avoid splitting string literals which are assumed to be on one line when
> printed?

It ends up at about 96 cols, but it's within limits.
The patch may have been written before the new 100 col-width limit.

> 
> --
> With Best Regards,
> Andy Shevchenko