Re: [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

From: Vaittinen, Matti
Date: Tue Dec 22 2020 - 04:40:10 EST



On Tue, 2020-12-22 at 09:25 +0000, Yoshihiro Shimoda wrote:
> Hi Matti-san,
>
> > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM
> >
> > On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote:
> > > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda
> > > <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > > > Use dev_regmap_add_irq_chip() to simplify the code.
> > > >
> > > > Signed-off-by: Yoshihiro Shimoda <
> > > > yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > > > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Reviewed-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
>
> Thank you for your review!
>
> > I thought I did review this earlier...
>
> You're correct. I'm sorry, I completely overlooked your Reviewed-by
> tag in previous.

It happens :) But of you re-spin the series, please revise the tags for
patches. I think I did review almost all of them (except the SPDX-
patches as I am not competent on licenses...)

>
> Best regards,
> Yoshihiro Shimoda
>