Re: [PATCH v11 10/11] mm/hugetlb: Gather discrete indexes of tail page

From: Oscar Salvador
Date: Tue Dec 22 2020 - 11:30:42 EST


On Tue, Dec 22, 2020 at 10:24:39PM +0800, Muchun Song wrote:
> +#else
> +static inline void hwpoison_subpage_deliver(struct hstate *h, struct page *head)
> +{
> +}
> +
> +static inline void hwpoison_subpage_set(struct hstate *h, struct page *head,
> + struct page *page)
> +{
> + if (PageHWPoison(head) && page != head) {
> + /*
> + * Move PageHWPoison flag from head page to the raw error page,
> + * which makes any subpages rather than the error page reusable.
> + */
> + SetPageHWPoison(page);
> + ClearPageHWPoison(head);
> + }
> +}
> +#endif

Sorry, I guess I should have made a more clear statement.
This patch should really be about changing the numeric index to its symbolic
names, so the #ifdef handling of hwpoison_subpage_* should have been gone into
patch#6.

I will have a closer look later on though.

--
Oscar Salvador
SUSE L3