Re: [PATCH] enic: Remove redundant free in enic_set_ringparam

From: Jakub Kicinski
Date: Wed Dec 23 2020 - 15:38:30 EST


On Wed, 23 Dec 2020 20:38:33 +0800 Dinghao Liu wrote:
> The error handling paths in enic_alloc_vnic_resources()
> have called enic_free_vnic_resources() before returning.
> So we may not need to call it again on failure at caller
> side.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>

But it's harmless, right? So the patch is just a cleanup not a fix?

In that case, could you please repost in two weeks? We're currently
in the merge window period, we're only accepting fixes to the
networking trees.

Thanks!