RE: [PATCH v6 11/12] mfd: bd9571mwv: Make the driver more generic

From: Yoshihiro Shimoda
Date: Thu Dec 24 2020 - 03:28:30 EST


Hi Lee,

> From: Lee Jones, Sent: Thursday, December 24, 2020 4:34 PM
> > Hi Lee,
> >
> > > From: Lee Jones, Sent: Thursday, December 24, 2020 12:39 AM
> > > On Wed, 23 Dec 2020, Yoshihiro Shimoda wrote:
> > > > From: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx>
<snip>
> > > > + switch (ret) {
> > > > + case BD9571MWV_PRODUCT_CODE_BD9571MWV:
> > > > + ddata = &bd9571mwv_ddata;
> > >
> > > Simply declare 'const struct mfd_cell *cells' locally in probe and
> > > assign it here instead.
> >
> > I got it. I'll also add "const struct regmap_config *regmap_config;"
> > and "const struct regmap_irq_chip *irq_chip;" locally in probe.
>
> If you only use them there, then yes, that's correct.

Thank you for the reply. Yes, I only use them there.
So, I have submitted v7 patches which have such implementation.

Best regards,
Yoshihiro Shimoda