Re: [PATCH v7 08/12] media: uvcvideo: Use dev_ printk aliases

From: Andy Shevchenko
Date: Thu Dec 24 2020 - 08:00:34 EST


On Wed, Dec 23, 2020 at 3:39 PM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote:
>
> Replace all the uses of printk() and uvc_printk() with its
> equivalent dev_ alias macros.

> Modify uvc_warn_once() macro to use dev_info instead printk().

...

> +#define uvc_warn_once(_dev, warn, fmt, ...) \
> +do { \
> + if (!test_and_set_bit(warn, &(_dev)->warnings)) \
> + dev_info(&(_dev)->udev->dev, fmt, ##__VA_ARGS__); \
> +} while (0)

...

Why not to use dev_warn_once() instead?

--
With Best Regards,
Andy Shevchenko