Re: [PATCH v6 1/2] PCI: cadence: Retrain Link to work around Gen2 training defect.

From: Thomas Petazzoni
Date: Tue Dec 29 2020 - 16:23:07 EST


Hello,

The commit title is incorrect, it doesn't match what the patch is doing.

On Mon, 28 Dec 2020 15:05:09 +0100
Nadeem Athani <nadeem@xxxxxxxxxxx> wrote:

> Moving the function above to remove compilation error.
> No changes in function.

Which compilation error? I guess there is no compilation error, except
after your apply your PATCH 2/2. Is this correct ?

If so, this should be explained in this commit log: "Move the function
cdns_pcie_host_wait_for_link() further up in the file, as it's going to
be used by upcoming additional code in the driver."

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com