Re: [PATCH] [v2] i915: fix shift warning

From: Chris Wilson
Date: Sun Jan 03 2021 - 09:03:21 EST


Quoting Arnd Bergmann (2021-01-03 13:51:44)
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Randconfig builds on 32-bit machines show lots of warnings for
> the i915 driver for passing a 32-bit value into __const_hweight64():
>
> drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:2584:9: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
> return hweight64(VDBOX_MASK(&i915->gt));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/asm-generic/bitops/const_hweight.h:29:49: note: expanded from macro 'hweight64'
> #define hweight64(w) (__builtin_constant_p(w) ? __const_hweight64(w) : __arch_hweight64(w))
>
> Change it to hweight_long() to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Reviewed-by:: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris