Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[]

From: Dmitry Torokhov
Date: Mon Jan 04 2021 - 18:37:37 EST


On Tue, Dec 29, 2020 at 01:15:10PM +0530, Souptick Joarder wrote:
> On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> >
> > Kernel test robot throws below warning ->
> >
> > >> drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable
> > >> 'ariel_pwrbutton_id_table' [-Wunused-const-variable]
> > static const struct spi_device_id ariel_pwrbutton_id_table[] = {
> > ^
> > 1 warning generated.
> >
> > Remove unused variable ariel_pwrbutton_id_table[] if no plan to use
> > it further.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>
> Any comment on this patch ?

Lubomir, would you prefer to remove the table or add it to the driver
structure as ariel_pwrbutton_driver->id_table?

Thanks.

--
Dmitry