Re: [PATCH v3 net-next] net: kcm: Replace fput with sockfd_put

From: David Miller
Date: Tue Jan 05 2021 - 19:03:57 EST


From: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>
Date: Wed, 30 Dec 2020 17:18:09 +0800

> The function sockfd_lookup uses fget on the value that is stored in
> the file field of the returned structure, so fput should ultimately be
> applied to this value. This can be done directly, but it seems better
> to use the specific macro sockfd_put, which does the same thing.
>
> Perform a source code refactoring by using the following semantic patch.
>
> // <smpl>
> @@
> expression s;
> @@
>
> s = sockfd_lookup(...)
> ...
> + sockfd_put(s);
> - fput(s->file);
> // </smpl>
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx>

Applied.