Re: [PATCH] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified

From: Jonathan Neuschäfer
Date: Fri Jan 08 2021 - 07:45:16 EST


On Fri, Jan 08, 2021 at 01:28:03PM +0100, Jonathan Neuschäfer wrote:
> The NPCM750 Timer/Watchdoc Controller has multiple interrupt lines,
^^^^^^^^

oops, that's a typo.

> connected to multiple timers. The driver uses timer 0 for timer
> interrupts, so the interrupt line corresponding to timer 0 should be
> specified in DT.
>
> I removed the mention of "flags for falling edge", because the timer
> controller uses high-level interrupts rather than falling-edge
> interrupts, and whether flags should be specified is up the interrupt
> controller's DT binding.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> ---
> .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> index ea22dfe485bee..97258f1a1505b 100644
> --- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> @@ -6,8 +6,7 @@ timer counters.
> Required properties:
> - compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
> - reg : Offset and length of the register set for the device.
> -- interrupts : Contain the timer interrupt with flags for
> - falling edge.
> +- interrupts : Contain the timer interrupt of timer 0.
> - clocks : phandle of timer reference clock (usually a 25 MHz clock).
>
> Example:
> --
> 2.29.2
>

Attachment: signature.asc
Description: PGP signature