Re: [RFC PATCH v2] selinux: security: Move selinux_state to a separate page

From: Miguel Ojeda
Date: Fri Jan 08 2021 - 10:26:36 EST


On Fri, Jan 8, 2021 at 10:52 AM Preeti Nagar <pnagar@xxxxxxxxxxxxxx> wrote:
>
> We want to seek your suggestions and comments on the idea and the changes
> in the patch.

Not sure why I was Cc'd, but I have a quick comment nevertheless.

> +#ifdef CONFIG_SECURITY_RTIC
> +struct selinux_state selinux_state __rticdata;
> +#else
> struct selinux_state selinux_state;
> +#endif

If you define an empty __rticdata for the !CONFIG case, then we don't
need #ifdefs for uses like this.

Cheers,
Miguel