Re: [PATCH] Driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()

[Greg KH]

On Mon, Dec 21, 2020 at 10:30:55PM +0800, John Garry wrote:
> The current check of nvec < minvec for nvec returned from
> platform_irq_count() will not detect a negative error code in nvec.
> 
> This is because minvec is unsigned, and, as such, nvec is promoted to
> unsigned in that check, which will make it a huge number (if it contained
> -EPROBE_DEFER).
> 
> In practice, an error should not occur in nvec for the only in-tree
> user, but add a check anyway.
> 
> Fixes: e15f2fa959f2 ("driver core: platform: Add devm_platform_get_irqs_affinity()")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
> I hope that this can go through either irqchip or driver/core trees, thanks!

I'll take it, thanks.

greg k-h