Re: [PATCH 17/40] drm/amd/display/dc/bios/bios_parser: Make local functions static

From: Alex Deucher
Date: Fri Jan 08 2021 - 15:41:50 EST


Applied. Thanks!

Alex

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2588:16: warning: no previous prototype for ‘update_slot_layout_info’ [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:2692:16: warning: no previous prototype for ‘get_bracket_layout_record’ [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Leo Li <sunpeng.li@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Christian König" <christian.koenig@xxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Igor Kravchenko <Igor.Kravchenko@xxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/bios/bios_parser.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
> index 23a373ca94b5c..f054c5872c619 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser.c
> @@ -2585,7 +2585,7 @@ static struct integrated_info *bios_parser_create_integrated_info(
> return NULL;
> }
>
> -enum bp_result update_slot_layout_info(
> +static enum bp_result update_slot_layout_info(
> struct dc_bios *dcb,
> unsigned int i,
> struct slot_layout_info *slot_layout_info,
> @@ -2689,7 +2689,7 @@ enum bp_result update_slot_layout_info(
> }
>
>
> -enum bp_result get_bracket_layout_record(
> +static enum bp_result get_bracket_layout_record(
> struct dc_bios *dcb,
> unsigned int bracket_layout_id,
> struct slot_layout_info *slot_layout_info)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel