Re: [PATCH 25/40] drm/amd/display/dc/dce/dce_link_encoder: Make functions invoked by reference static

[Alex Deucher]

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1200:6: warning: no previous prototype for ‘dce60_link_encoder_enable_dp_output’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1239:6: warning: no previous prototype for ‘dce60_link_encoder_enable_dp_mst_output’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_link_encoder.c:1429:6: warning: no previous prototype for ‘dce60_link_encoder_dp_set_phy_pattern’ [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Leo Li <sunpeng.li@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Christian König" <christian.koenig@xxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Mauro Rossi <issor.oruam@xxxxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> index 210466b2d8631..0ef2f4d9d8bf3 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> @@ -1197,7 +1197,7 @@ void dce110_link_encoder_enable_dp_mst_output(
>
>  #if defined(CONFIG_DRM_AMD_DC_SI)
>  /* enables DP PHY output */
> -void dce60_link_encoder_enable_dp_output(
> +static void dce60_link_encoder_enable_dp_output(
>         struct link_encoder *enc,
>         const struct dc_link_settings *link_settings,
>         enum clock_source_id clock_source)
> @@ -1236,7 +1236,7 @@ void dce60_link_encoder_enable_dp_output(
>  }
>
>  /* enables DP PHY output in MST mode */
> -void dce60_link_encoder_enable_dp_mst_output(
> +static void dce60_link_encoder_enable_dp_mst_output(
>         struct link_encoder *enc,
>         const struct dc_link_settings *link_settings,
>         enum clock_source_id clock_source)
> @@ -1426,7 +1426,7 @@ void dce110_link_encoder_dp_set_phy_pattern(
>
>  #if defined(CONFIG_DRM_AMD_DC_SI)
>  /* set DP PHY test and training patterns */
> -void dce60_link_encoder_dp_set_phy_pattern(
> +static void dce60_link_encoder_dp_set_phy_pattern(
>         struct link_encoder *enc,
>         const struct encoder_set_dp_phy_pattern_param *param)
>  {
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel