Re: [PATCH 35/40] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment

[Alex Deucher]

On Fri, Jan 8, 2021 at 3:16 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In function ‘adjust_display_pll_v2’:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1462:11: warning: unused variable ‘pixel_clock_10KHz_in’ [-Wunused-variable]
>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Leo Li <sunpeng.li@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Christian König" <christian.koenig@xxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

See my comment on the other patch for this function.

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/bios/command_table.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> index dd893a1176979..66fe1d1810789 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> @@ -1457,10 +1457,6 @@ static enum bp_result adjust_display_pll_v2(
>  {
>         enum bp_result result = BP_RESULT_FAILURE;
>
> -       /* We need to convert from KHz units into 10KHz units and then convert
> -        * output pixel clock back 10KHz-->KHz */
> -       uint32_t pixel_clock_10KHz_in = bp_params->pixel_clock / 10;
> -
>         bp->cmd_helper->encoder_id_to_atom(
>                 dal_graphics_object_id_get_encoder_id(bp_params->encoder_object_id));
>         bp->cmd_helper->encoder_mode_bp_to_atom(bp_params->signal_type, false);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel