RE: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls

From: Chen, Mike Ximing
Date: Sat Jan 09 2021 - 01:30:36 EST


> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, January 7, 2021 2:41 PM
> To: Chen, Mike Ximing <mike.ximing.chen@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; arnd@xxxxxxxx; Williams, Dan J
> <dan.j.williams@xxxxxxxxx>; pierre-louis.bossart@xxxxxxxxxxxxxxx; Gage Eads
> <gage.eads@xxxxxxxxx>
> Subject: Re: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls
>
> > diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst
> b/Documentation/userspace-api/ioctl/ioctl-number.rst
> > index 55a2d9b2ce33..afca043d59f8 100644
> > --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
> > +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> > @@ -241,6 +241,7 @@ Code Seq# Include File
> Comments
> > 'h' 00-7F conflict! Charon filesystem
> > <mailto:zapman@xxxxxxxxxxxx>
> > 'h' 00-1F linux/hpet.h conflict!
> > +'h' 00-1F uapi/linux/dlb.h conflict!
>
> Why are you taking a range that you know there is a conflict for?

OK. We will switch to a unused magic number and range, probably 0x81 00-1F.
Thanks