Re: [PATCH] ACPI: scan: Fix a Hyper-V Linux VM panic caused by buffer overflow

From: Rafael J. Wysocki
Date: Sat Jan 09 2021 - 12:09:24 EST


On Saturday, January 9, 2021 10:37:41 AM CET Dexuan Cui wrote:
> > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Sent: Saturday, January 9, 2021 12:52 AM
> >>
> >> Hi Rafael, Len, and all,
> >> Can you please take a look at the v2 patch?
> >>
> >> The Linux mainline has been broken for several weeks when it
> >> runs as a guest on Hyper-V, so we'd like this to be fixed ASAP,
> >> as more people are being affected
> >
> > I would like to see a warning printed when the dupped
> > string violates the spec.
>
> Hi Andy,
> Do you want a simple strlen() check like the below, or a full
> check of the AAA#### or NNNN#### format?

It would be good to check the format too while at it.

> Can we have the v2 (https://lkml.org/lkml/2021/1/8/53) merged
> first, and then we can add another patch for the format checking?

Yes, we can.

I'm going to apply the v2 early next week.

Thanks!