Re: [PATCH v7 08/18] virt: acrn: Introduce EPT mapping management

From: Shuo A Liu
Date: Sun Jan 10 2021 - 23:04:33 EST


On Fri 8.Jan'21 at 16:34:06 +0100, Greg Kroah-Hartman wrote:
On Wed, Jan 06, 2021 at 03:50:45PM +0800, shuo.a.liu@xxxxxxxxx wrote:
+/**
+ * struct acrn_vm_memmap - A EPT memory mapping info for a User VM.
+ * @type: Type of the memory mapping (ACRM_MEMMAP_*).
+ * Pass to hypervisor directly.
+ * @attr: Attribute of the memory mapping.
+ * Pass to hypervisor directly.
+ * @user_vm_pa: Physical address of User VM.
+ * Pass to hypervisor directly.
+ * @service_vm_pa: Physical address of Service VM.
+ * Pass to hypervisor directly.
+ * @vma_base: VMA address of Service VM. Pass to hypervisor directly.
+ * @len: Length of the memory mapping.
+ * Pass to hypervisor directly.
+ */
+struct acrn_vm_memmap {
+ __u32 type;
+ __u32 attr;
+ __u64 user_vm_pa;
+ union {
+ __u64 service_vm_pa;
+ __u64 vma_base;
+ };
+ __u64 len;
+};

Endianness?

Same consideration within patch 06/18. Need i specify these values? They
are more like ioctls' paramter values.

Thanks
shuo