Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish_fault() codepaths

From: Will Deacon
Date: Mon Jan 11 2021 - 09:28:25 EST


On Mon, Jan 11, 2021 at 05:26:20PM +0300, Kirill A. Shutemov wrote:
> On Fri, Jan 08, 2021 at 05:15:15PM +0000, Will Deacon wrote:
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index ecdf8a8cd6ae..801dd99f733c 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -542,8 +542,8 @@ struct vm_fault {
> > * is not NULL, otherwise pmd.
> > */
> > pgtable_t prealloc_pte; /* Pre-allocated pte page table.
> > - * vm_ops->map_pages() calls
> > - * alloc_set_pte() from atomic context.
> > + * vm_ops->map_pages() sets up a page
> > + * table from from atomic context.
> > * do_fault_around() pre-allocates
> > * page table to avoid allocation from
> > * atomic context.
>
> The typo Matthew has pointed out:
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index d3d4e307fa09..358fc8616d8b 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -535,7 +535,7 @@ struct vm_fault {
> */
> pgtable_t prealloc_pte; /* Pre-allocated pte page table.
> * vm_ops->map_pages() sets up a page
> - * table from from atomic context.
> + * table from atomic context.
> * do_fault_around() pre-allocates
> * page table to avoid allocation from
> * atomic context.

Cheers, fixed locally and will include for v3!

Will