Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

From: Mark Brown
Date: Mon Jan 11 2021 - 12:07:26 EST


On Mon, Jan 11, 2021 at 08:41:19AM -0800, Florian Fainelli wrote:

> > [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison
> > commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8

> I don't think that "style: " is a subject prefix that is used commonly
> and it certainly should not belong in a commit subject. Mark can you
> please people at least 10-12 hours to review changes before applying
> them? This one is trivial except the commit subject does not match
> previous changes done to this file and it should have been fixed.

Honestly for super trivial stuff like this I'm not sure it's a useful
use of anyone's time to police this sort of stuff aggressively, it's
after the prefixes that matter so I saw it easily and I'm having a hard
time caring that it happens to be done as a prefix rather than saying
style somewhere else in the subject.

I will generally hold off for longer with these trivial patches on
things where I expect to see some review but that's felt a bit patchy
with the Broadcom drivers.

Attachment: signature.asc
Description: PGP signature