Re: [PATCH 1/2] lib/cmdline: add new function get_option_ull()

From: Andy Shevchenko
Date: Mon Jan 11 2021 - 12:23:49 EST


On Mon, Jan 11, 2021 at 08:33:17AM -0800, Wesley Zhao wrote:
> From: "Wesley.Zhao" <zhaowei1102@xxxxxxxxxxxxxxx>
>
> In the future we would pass the unsigned long long parameter
> like(0x123456781234) in cmdline on the 64bit platform, so add a new
> option parse function get_option_ull()

No negative numbers?
No test cases?
No user?

Please, address above.

Besides that, consider to deduplicate (like it's done in simple_strto*() family
of functions), so we don't have two implementation that are basically do the
same, only put result to a different type of variable.

--
With Best Regards,
Andy Shevchenko