Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirks for DeeQ X5-Z8300
From: Pierre-Louis Bossart
Date: Mon Jan 11 2021 - 15:30:19 EST
On 12/15/20 10:16 PM, Chris Chiu wrote:
DeeQ X5-Z8300 is a laptop empowered by Intel Atom Cherry Trail. Add
quirks to select the correct input map, jack-detect options to enable
jack sensing and internal/headset microphones.
Signed-off-by: Chris Chiu <chiu@xxxxxxxxxxxxx>
You probably need to re-send and CC: maintainers (Mark Brown, Takashi
Iwai) and Hans de Goede who's been supporting all those quirks.
I don't think the changes below are fully correct, most quirks start with
.driver_data = (void *)(BYT_RT5651_DEFAULT_QUIRKS |
which e.g. enables the MCLK and overcurrent handling.
I wonder if what you need is
.driver_data = (void *)(BYT_RT5651_DEFAULT_QUIRKS | BYT_RT5651_IN1_IN2_MAP)
---
sound/soc/intel/boards/bytcr_rt5651.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c
index 688b5e0a49e3..9df09e26b05a 100644
--- a/sound/soc/intel/boards/bytcr_rt5651.c
+++ b/sound/soc/intel/boards/bytcr_rt5651.c
@@ -507,6 +507,14 @@ static const struct dmi_system_id byt_rt5651_quirk_table[] = {
BYT_RT5651_SSP0_AIF1 |
BYT_RT5651_MONO_SPEAKER),
},
+ {
+ .callback = byt_rt5651_quirk_cb,
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "DeeQ"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "X5-Z8300"),
+ },
+ .driver_data = (void *)(BYT_RT5651_IN1_IN2_MAP | BYT_RT5651_JD1_1),
+ },
{}
};