Re: linux-next: Fixes tag needs some work in the spi tree

From: Pratyush Yadav
Date: Mon Jan 11 2021 - 15:59:17 EST


+Cc checkpatch.pl maintainers.

On 12/01/21 07:36AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 2ef0170e9039 ("spi: cadence-quadspi: Fix build warning on 32-bit platforms")
>
> Fixes tag
>
> Fixes: f453f293979f ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Did yu mean
>
> Fixes: f453f293979f ("spi: cadence-quadspi: Add DTR support")
>
> or
>
> Fixes: 0920a32cf6f2 ("spi: cadence-quadspi: Wait at least 500 ms for direct reads")

I meant this one. My mistake. Copied the wrong hash. Any way to fix this
now?

This check should probably be added in checkpatch.pl so mistakes like
this can be avoided in the future.

--
Regards,
Pratyush Yadav
Texas Instruments India