Re: [PATCH 0/6] fs: deduplicate compat logic

From: Al Viro
Date: Mon Jan 11 2021 - 19:59:29 EST


On Mon, Jan 11, 2021 at 07:30:11PM -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@xxxxxxxxxx>
>
> Use in_compat_syscall() to differentiate compat handling exactly
> where needed, including in nested function calls. Then remove
> duplicated code in callers.

IMO it's a bad idea. Use of in_compat_syscall() is hard to avoid
in some cases, but let's not use it without a good reason. It
makes the code harder to reason about.