Re: [PATCH v17 04/26] x86/cpufeatures: Introduce X86_FEATURE_CET and setup functions

From: Borislav Petkov
Date: Tue Jan 12 2021 - 07:39:39 EST


On Mon, Jan 11, 2021 at 03:09:00PM -0800, Yu-cheng Yu wrote:
> @@ -1252,6 +1260,16 @@ static void __init cpu_parse_early_param(void)
> if (cmdline_find_option_bool(boot_command_line, "noxsaves"))
> setup_clear_cpu_cap(X86_FEATURE_XSAVES);
>
> + /*
> + * CET states are XSAVES states and options must be parsed early.
> + */

That comment is redundant - look at the containing function's name.

Otherwise patch looks just as it should.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette