Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

From: Jakub Kicinski
Date: Tue Jan 12 2021 - 19:55:48 EST


On Tue, 12 Jan 2021 11:55:11 -0800 Praveen Chaudhary wrote:
> Hi Jakub
>
> Thanks for the review,
>
> Sure, I will reraise the patch (again v0i, sonce no code changes) after adding space before '<'.
>
> This patch adds lines in 'include/uapi/', that requires ABI version changes for debian build. I am not sure, if we need any such changes to avoid breaking allmodconfig. It will be really helpful, if you can look at the patch once 'https://lkml.org/lkml/2021/1/11/1668' and suggest on this. Thanks a lot again.

The code doesn't build, AFAIK it's because:

net/ipv6/ndisc.c:1322:8: error: too few arguments to function ‘rt6_add_dflt_router’