Re: [PATCH 04/15] dt_bindings: bd71828: Add clock output mode

[Matti Vaittinen]

On Wed, 2021-01-13 at 07:52 -0600, Rob Herring wrote:
> On Fri, Jan 08, 2021 at 03:34:16PM +0200, Matti Vaittinen wrote:
> > The BD71828 allows configuring the clk32kout pin mode to CMOS or
> > open-drain. Add device-tree property for specifying the preferred
> > mode.
> > 
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/mfd/rohm,bd71828-pmic.yaml         | 7
> > +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-
> > pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-
> > pmic.yaml
> > index 3a6a1a26e2b3..cba085836bc0 100644
> > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> > @@ -44,6 +44,13 @@ properties:
> >    clock-output-names:
> >      const: bd71828-32k-out
> >  
> > +  rohm,clkout-mode:
> > +    description: clk32kout mode. Can be set to "open-drain" or
> > "cmos".
> > +    $ref: "/schemas/types.yaml#/definitions/string"
> > +    enum:
> > +      - open-drain
> > +      - cmos
> > +
> 
> I think a boolean or tristate ((0/1/not present) if you need 'leave 
> default') would be better.

I was thinking of boolean but I hit the exact problem of leaving the
default. (Booleans are so tempting for a lazy coder like me :] ) Do you
mean uint with allowed values of 0/1 with the tristated? I can sure do
that - but wouldn't open-drain / cmos be more descriptive?

Best Regards
	Matti Vaittinen