Re: [PATCHv2 00/22] perf tools: Add daemon command

[Jiri Olsa]

ping, any reviews?

thanks,
jirka

On Sat, Jan 02, 2021 at 11:04:19PM +0100, Jiri Olsa wrote:
> hi,
> we were asked for possibility to be able run record
> sessions on background.
> 
> This patchset adds support to configure and run record
> sessions on background via new 'perf daemon' command.
> 
> Please check below the example on usage.
> 
> The patchset is based on following control changes:
>   https://lore.kernel.org/lkml/20201226232038.390883-1-jolsa@xxxxxxxxxx/
> 
> Available also here:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/daemon
> 
> v2 changes:
>   - switch options to sub-commands [Namhyung]
>   - use signalfd to track on sessions [Alexei]
>   - use stop command to stop sessions [Alexei]
>   - couple minor fixes [Alexei]
>   - more detailed changelogs [Arnaldo]
>   - added tests
> 
> thanks,
> jirka
> 
> 
> ---
> Jiri Olsa (22):
>       perf tools: Make perf_config_from_file static
>       perf tools: Add config set interface
>       perf tools: Add debug_set_display_time function
>       perf tools: Add perf_home_perfconfig function
>       perf tools: Make perf_config_system global
>       perf tools: Make perf_config_global gobal
>       perf daemon: Add daemon command
>       perf daemon: Add config file change check
>       perf daemon: Add signalfd support
>       perf daemon: Add signal command
>       perf daemon: Add stop command
>       perf daemon: Allow only one daemon over base directory
>       perf daemon: Set control fifo for session
>       perf daemon: Add ping command
>       perf daemon: Use control to stop session
>       perf daemon: Add up time for daemon/session list
>       perf daemon: Add man page for perf-daemon
>       perf test: Add daemon list command test
>       perf test: Add daemon reconfig test
>       perf test: Add daemon stop command test
>       perf test: Add daemon signal command test
>       perf test: Add daemon ping command test
> 
>  tools/perf/Build                         |    1 +
>  tools/perf/Documentation/perf-config.txt |   14 ++
>  tools/perf/Documentation/perf-daemon.txt |  187 ++++++++++++++++
>  tools/perf/builtin-daemon.c              | 1327 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  tools/perf/builtin.h                     |    1 +
>  tools/perf/command-list.txt              |    1 +
>  tools/perf/perf.c                        |    1 +
>  tools/perf/tests/shell/daemon.sh         |  388 ++++++++++++++++++++++++++++++++
>  tools/perf/util/config.c                 |  123 +++++++----
>  tools/perf/util/config.h                 |    7 +-
>  tools/perf/util/debug.c                  |   34 ++-
>  tools/perf/util/debug.h                  |    1 +
>  12 files changed, 2037 insertions(+), 48 deletions(-)
>  create mode 100644 tools/perf/Documentation/perf-daemon.txt
>  create mode 100644 tools/perf/builtin-daemon.c
>  create mode 100755 tools/perf/tests/shell/daemon.sh
> 
> 
> ---
> Example with 2 record sessions:
> 
>   # cat ~/.perfconfig
>   [daemon]
>   base=/opt/perfdata
> 
>   [session-cycles]
>   run = -m 10M -e cycles --overwrite --switch-output -a
> 
>   [session-sched]
>   run = -m 20M -e sched:* --overwrite --switch-output -a
> 
> 
> Starting the daemon:
> 
>   # perf daemon start
> 
> 
> Check sessions:
> 
>   # perf daemon
>   [603349:daemon] base: /opt/perfdata
>   [603350:cycles] perf record -m 10M -e cycles --overwrite --switch-output -a
>   [603351:sched] perf record -m 20M -e sched:* --overwrite --switch-output -a
> 
> First line is daemon process info with configured daemon base.
> 
> 
> Check sessions with more info:
> 
>   # perf daemon -v
>   [603349:daemon] base: /opt/perfdata
>     output:  /opt/perfdata/output
>     lock:    /opt/perfdata/lock
>     up:      1 minutes
>   [603350:cycles] perf record -m 10M -e cycles --overwrite --switch-output -a
>     base:    /opt/perfdata/session-cycles
>     output:  /opt/perfdata/session-cycles/output
>     control: /opt/perfdata/session-cycles/control
>     ack:     /opt/perfdata/session-cycles/ack
>     up:      1 minutes
>   [603351:sched] perf record -m 20M -e sched:* --overwrite --switch-output -a
>     base:    /opt/perfdata/session-sched
>     output:  /opt/perfdata/session-sched/output
>     control: /opt/perfdata/session-sched/control
>     ack:     /opt/perfdata/session-sched/ack
>     up:      1 minutes
> 
> The 'base' path is daemon/session base.
> The 'lock' file is daemon's lock file guarding that no other
> daemon is running on top of the base.
> The 'output' file is perf record output for specific session.
> The 'control' and 'ack' files are perf control files.
> The 'up' number shows minutes daemon/session is running.
> 
> 
> Make sure control session is online:
> 
>   # perf daemon ping
>   OK   cycles
>   OK   sched
> 
> 
> Send USR2 signal to session 'cycles' to generate perf.data file:
> 
>   # perf daemon signal --session cycles
>   signal 12 sent to session 'cycles [603452]'
> 
>   # tail -2  /opt/perfdata/session-cycles/output
>   [ perf record: dump data: Woken up 1 times ]
>   [ perf record: Dump perf.data.2020123017013149 ]
> 
> 
> Send USR2 signal to all sessions:
> 
>   # perf daemon signal
>   signal 12 sent to session 'cycles [603452]'
>   signal 12 sent to session 'sched [603453]'
> 
>   # tail -2  /opt/perfdata/session-cycles/output
>   [ perf record: dump data: Woken up 1 times ]
>   [ perf record: Dump perf.data.2020123017024689 ]
>   # tail -2  /opt/perfdata/session-sched/output
>   [ perf record: dump data: Woken up 1 times ]
>   [ perf record: Dump perf.data.2020123017024713 ]
> 
> 
> Stop daemon:
> 
>   # perf daemon stop
>