Re: [PATCH 01/22] perf tools: Make perf_config_from_file static

From: Arnaldo Carvalho de Melo
Date: Mon Jan 18 2021 - 10:53:35 EST


Em Sat, Jan 02, 2021 at 11:04:20PM +0100, Jiri Olsa escreveu:
> It's not used outside config.c object.

Thanks, applied.

> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
> tools/perf/util/config.c | 2 +-
> tools/perf/util/config.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
> index 6969f82843ee..20be0504fb95 100644
> --- a/tools/perf/util/config.c
> +++ b/tools/perf/util/config.c
> @@ -489,7 +489,7 @@ int perf_default_config(const char *var, const char *value,
> return 0;
> }
>
> -int perf_config_from_file(config_fn_t fn, const char *filename, void *data)
> +static int perf_config_from_file(config_fn_t fn, const char *filename, void *data)
> {
> int ret;
> FILE *f = fopen(filename, "r");
> diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h
> index 8c881e3a3ec3..2f753b2a034b 100644
> --- a/tools/perf/util/config.h
> +++ b/tools/perf/util/config.h
> @@ -27,7 +27,6 @@ extern const char *config_exclusive_filename;
>
> typedef int (*config_fn_t)(const char *, const char *, void *);
>
> -int perf_config_from_file(config_fn_t fn, const char *filename, void *data);
> int perf_default_config(const char *, const char *, void *);
> int perf_config(config_fn_t fn, void *);
> int perf_config_int(int *dest, const char *, const char *);
> --
> 2.26.2
>

--

- Arnaldo