Re: [PATCH 2/3] net: usb: log errors to dmesg/syslog

[Grant Grundler]

+nic_swsd [adding per Realtek developer team request]

On Sat, Jan 16, 2021 at 5:27 AM Grant Grundler <grundler@xxxxxxxxxxxx> wrote:
>
> Errors in protocol should be logged when the driver aborts operations.
> If the driver can carry on and "humor" the device, then emitting
> the message as debug output level is fine.
>
> Signed-off-by: Grant Grundler <grundler@xxxxxxxxxxxx>
> ---
>  drivers/net/usb/usbnet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 1447da1d5729..bc7b93399bd5 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -887,7 +887,7 @@ int usbnet_open (struct net_device *net)
>
>         // insist peer be connected
>         if (info->check_connect && (retval = info->check_connect (dev)) < 0) {
> -               netif_dbg(dev, ifup, dev->net, "can't open; %d\n", retval);
> +               netif_err(dev, ifup, dev->net, "can't open; %d\n", retval);
>                 goto done;
>         }
>
> --
> 2.29.2
>