Re: [PATCH] printk: fix buffer overflow potential for print_text()

From: John Ogness
Date: Tue Jan 19 2021 - 07:00:22 EST


On 2021-01-19, Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> wrote:
>>> John, how did you spot these problems?
>>
>> I am preparing my series to remove the logbuf_lock, which also
>> refactors and consolidates code from syslog_print_all() and
>> kmsg_dump_get_buffer(). While testing/verifying my series, I noticed
>> the these oddities in the semantics and decided I should research
>> where they came from and if they were actually necessary.
>
> Any chance you can put those tests somewhere public so that we can
> run them regularly?

I have a collection of hacked-together tools that I use to test most of
the various interfaces of printk. I would need to clean them up if they
should be used for any kind of automated regression testing.

And where should I make such things available? I could put them in a
repo in the Linutronix github account (like I did for the ringbuffer
stress testing tool). (??)

John