Re: [PATCH 6/6] arm64: dts: renesas: falcon: Enable MMC

From: Wolfram Sang
Date: Tue Jan 19 2021 - 08:02:35 EST



> > + reg_1p8v: regulator0 {
>
> Please use a better node name, to avoid accidental duplicates, cfr. commit
> 45f5d5a9e34d3fe4 ("arm64: dts: renesas: r8a77995: draak: Fix backlight
> regulator name")

Done.

> > + no-sd;
> > + no-sdio;
>
> I'm no expert on the no-sd{,io} properties.
> Just wondering if we need them on other R-Car gen3 boards with eMMC, too/

Won't hurt. I'll prepare something...

Thanks!

Attachment: signature.asc
Description: PGP signature